feat: [DBOPS-1363]: Onboarding two new static steps LiquibaseUpdateSQLStep & LiquibaseRollbackSQLStep#627
Open
bikramHarness wants to merge 1 commit intomainfrom
Open
feat: [DBOPS-1363]: Onboarding two new static steps LiquibaseUpdateSQLStep & LiquibaseRollbackSQLStep#627bikramHarness wants to merge 1 commit intomainfrom
bikramHarness wants to merge 1 commit intomainfrom
Conversation
bikramHarness
requested review from
abhinavmittal-harness,
abhinavsingh1196,
abosii-harness,
anilchowdhury-harness,
archit-harness,
deepharness,
dgarg-harness,
harshjain12,
hemanthmantri,
ivan-83,
nassergonzalez,
puthrayaharness,
rohitk-h,
utkarshchoubey-harness,
vikyathharekal,
vlica-harness and
yogesh-chauhan
as code owners
|
|
bikramHarness
force-pushed
the
dbops-1363
branch
from
f82b305 to
2b73859
Compare
| type: string | ||
| command: | ||
| type: string | ||
| settings: |
Contributor
There was a problem hiding this comment.
why only its present in update-sql and not rollback-sql
Contributor
There was a problem hiding this comment.
plus i think it should be globalSettings as per current field
Contributor
Author
There was a problem hiding this comment.
Same, copied from existing step
Comment on lines
+73
to
+91
| properties: | ||
| dbInstance: | ||
| type: string | ||
| dbSchema: | ||
| type: string | ||
| connectorRef: | ||
| type: string | ||
| settings: | ||
| oneOf: | ||
| - $ref: ../../common/parameter-field-map-string-json-node.yaml | ||
| - type: string | ||
| command: | ||
| type: string | ||
| delegateSelectors: | ||
| oneOf: | ||
| - type: array | ||
| items: | ||
| type: string | ||
| - type: string |
Contributor
There was a problem hiding this comment.
why its getting repeated again properties?
Contributor
Author
There was a problem hiding this comment.
Took this from the existing LiquibaseCustomCommand,
should we remove this
| - $ref: ../../steps/common/dbops-liquibase-command-step-node.yaml | ||
| - $ref: ../../steps/common/files-upload-step-node.yaml | ||
| - $ref: ../../steps/custom/event-listener-step-node.yaml | ||
| - $ref: ../../steps/common/dbops-liquibase-update-sql-step-node.yaml |
Contributor
There was a problem hiding this comment.
update not to have liquibase
bikramHarness
force-pushed
the
dbops-1363
branch
from
9b3d94d to
e68edbb
Compare
| - $ref: ../../steps/common/dbops-liquibase-command-step-node.yaml | ||
| - $ref: ../../steps/common/files-upload-step-node.yaml | ||
| - $ref: ../../steps/custom/event-listener-step-node.yaml | ||
| - $ref: ../../steps/common/db-schema-update-sql-step-node.yaml |
Contributor
There was a problem hiding this comment.
i dont think we need to support here, only cd and custom should be fine
Contributor
Author
There was a problem hiding this comment.
removed from approval stage
archit-harness
approved these changes
Jul 29, 2025
Abhishek-CDC
approved these changes
Jul 30, 2025
bot2-harness
force-pushed
the
dbops-1363
branch
from
62b845c to
798d5ca
Compare
…LStep & LiquibaseRollbackSQLStep
bot2-harness
force-pushed
the
dbops-1363
branch
from
798d5ca to
38520f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Onboarding two new static steps, LiquibaseUpdateSQLStep & LiquibaseRollbackSQLStep